New prune log spam

Development
1

I’m currently testing the new prune implementation (great work! :heart:) and seeing a huge log output. The prune run took ~16min and produced 57k log lines - that’s roughly 60 log lines per second like this:

[0:33] 2.93%  1235 / 42210 packs repacked
[0:33] 2.93%  1235 / 42210 packs repacked
[0:33] 2.93%  1236 / 42210 packs repacked
[0:33] 2.93%  1237 / 42210 packs repacked
[0:33] 2.93%  1237 / 42210 packs repacked
[0:33] 2.93%  1238 / 42210 packs repacked
[0:33] 2.94%  1239 / 42210 packs repacked
[0:33] 2.94%  1239 / 42210 packs repacked

I’m wondering if it is really necessary to output that many (repetitive) lines.

BTW, I’m aware of the --quiet flag.

2

@764287 https://github.com/restic/restic/pull/3112 reduces the log spam a lot. With that PR there’s only one log line per second. It would be possible to reduce that log interval further (or possibly revert to the old behavior of no progress update at all). These two options should be discussed in https://github.com/restic/restic/issues/2706 .

1 Like
3

Thanks for the fast respone - I’ll have a look and report back.

4

Just tested your PR and the log output is much more reasonable now. Thanks again!