Errors found by check: (1) Invalid type "irregular" (2) ciphertext verification failed

[MichaelEischer]

@punchcard

I have go1.17.8 installed for goofing around so does it need to be updated or deleted?

You need at least go 1.21 to compile the PR. To build the PR, either use git to clone it from GitHub - MichaelEischer/restic at fix-backup-irregular or just grab the zip file from https://github.com/MichaelEischer/restic/archive/refs/heads/fix-backup-irregular.zip . Then build it using go build ./cmd/restic. You don’t have to permanently install the resulting restic.exe binary. Just specify the path to it for the next backup.

@punchcard

For myself I don’t like the idea that a backup command doing a “fix” to the repository, a backup command should only add data. If this is just fixing the reporting of “irregular” that would be fine.

The PR does two things

• no longer include irregular files in a snapshot. Note that with the PR the backup command will still complain about irregular files, but those will no longer be included in the snapshot. Existing snapshots are not modified in any way.
• To remove irregular files from existing snapshots you can use the restic repair snapshots <ids> --forget command.

@fede

In my backup there is a folder of files encrypted with Cryptomator. Maybe that is the source of the problem? (Or for the bug itself)

That could be the case. Since Go 1.23 (used for restic 0.17.1) most reparse points (probably also used by Cryptomator under the hood) are treated as irregular files. The big problem there is that reparse points can significantly alter filesystem semantics with no way for restic (or Go) to known what to expect. Similarly, restore would previously just restore those files as plain files.